Re: [PATCH v2 25/34] gfs2: Convert gfs2_aspace_write_folio to bh_submit()

On Thu 28-05-26 18:31:38, Matthew Wilcox (Oracle) wrote:
> Avoid an extra indirect function call by using bh_submit() instead of
> submit_bh().
> 
> Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
> Cc: [email protected]

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

								Honza

> ---
>  fs/gfs2/meta_io.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
> index df5f05054f6e..4895bb010cfb 100644
> --- a/fs/gfs2/meta_io.c
> +++ b/fs/gfs2/meta_io.c
> @@ -59,7 +59,7 @@ static void gfs2_aspace_write_folio(struct folio *folio,
>  			continue;
>  		}
>  		if (test_clear_buffer_dirty(bh)) {
> -			mark_buffer_async_write(bh);
> +			set_buffer_async_write(bh);
>  		} else {
>  			unlock_buffer(bh);
>  		}
> @@ -75,7 +75,8 @@ static void gfs2_aspace_write_folio(struct folio *folio,
>  	do {
>  		struct buffer_head *next = bh->b_this_page;
>  		if (buffer_async_write(bh)) {
> -			submit_bh(REQ_OP_WRITE | write_flags, bh);
> +			bh_submit(bh, REQ_OP_WRITE | write_flags,
> +					bh_end_async_write);
>  			nr_underway++;
>  		}
>  		bh = next;
> @@ -221,7 +222,7 @@ static void gfs2_meta_read_endio(struct bio *bio)
>  
>  /*
>   * Submit several consecutive buffer head I/O requests as a single bio I/O
> - * request.  (See submit_bh_wbc.)
> + * request.  (See bh_submit.)
>   */
>  static void gfs2_submit_bhs(blk_opf_t opf, struct buffer_head *bhs[], int num)
>  {
> -- 
> 2.47.3
> 
-- 
Jan Kara <[email protected]>
SUSE Labs, CR