[PATCH] iomap: Remove FGP_NOFS from iomap_get_folio()

"Matthew Wilcox (Oracle)" <[email protected]> Wed, 24 Jun 2026 18:42:26 +0100
Newsgroups dev.linux.lists.gfs2,dev.linux.lists.fuse-devel,dev.linux.lists.ntfs3,org.kernel.vger.linux-block,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-xfs
Message-ID <[email protected]>
FGP_NOFS is legacy; filesystems should be using memalloc_nofs_save/restore
instead.  We have it here in iomap because it was buried in
grab_cache_page_write_begin() and we didn't want to change this behaviour
as part of the folio transition.

I have tested this with XFS and see no issues.  Other filesystems (cc'd)
may need to make adjustments.  Please test with lockdep enabled.

Cc: "Darrick J. Wong" <[email protected]> (iomap)
Cc: Jens Axboe <[email protected]> (block)
Cc: Namjae Jeon <[email protected]> (exfat, ntfs)
Cc: Sungjong Seo <[email protected]> (exfat)
Cc: Yuezhang Mo <[email protected]> (exfat)
Cc: Miklos Szeredi <[email protected]> (fuse)
Cc: Andreas Gruenbacher <[email protected]> (gfs2)
Cc: Hyunchul Lee <[email protected]> (ntfs)
Cc: Konstantin Komarov <[email protected]> (ntfs3)
Cc: Carlos Maiolino <[email protected]> (xfs)
Cc: Damien Le Moal <[email protected]> (zonefs)
Cc: Naohiro Aota <[email protected]> (zonefs)
Cc: Johannes Thumshirn <[email protected]> (zonefs)
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
---
 fs/iomap/buffered-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 8d4806dc46d4..27bc2455a98d 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -768,7 +768,7 @@ EXPORT_SYMBOL_GPL(iomap_is_partially_uptodate);
  */
 struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos, size_t len)
 {
-	fgf_t fgp = FGP_WRITEBEGIN | FGP_NOFS;
+	fgf_t fgp = FGP_WRITEBEGIN;
 
 	if (iter->flags & IOMAP_NOWAIT)
 		fgp |= FGP_NOWAIT;
-- 
2.47.3