Re: [PATCH] iomap: Remove FGP_NOFS from iomap_get_folio()
Christoph Hellwig <[email protected]> Thu, 25 Jun 2026 23:13:18 -0700
| Newsgroups | dev.linux.lists.gfs2,dev.linux.lists.fuse-devel,dev.linux.lists.ntfs3,org.kernel.vger.linux-block,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Jun 24, 2026 at 06:42:26PM +0100, Matthew Wilcox (Oracle) wrote: > FGP_NOFS is legacy; filesystems should be using memalloc_nofs_save/restore > instead. We have it here in iomap because it was buried in > grab_cache_page_write_begin() and we didn't want to change this behaviour > as part of the folio transition. > > I have tested this with XFS and see no issues. Other filesystems (cc'd) > may need to make adjustments. Please test with lockdep enabled. I think the most interesting one to test here would be gfs2 as it has rather alaborate locking in the write path.