Re: [PATCH v1 1/4] dt-bindings: lcdif: Add interface pixel format

On Fri, Jul 17, 2026 at 11:13:44PM +0200, Francesco Dolcini wrote:
> On Fri, Jul 17, 2026 at 10:57:54PM +0200, Francesco Dolcini wrote:
> > On Fri, Jul 17, 2026 at 10:55:51AM -0500, Frank Li wrote:
> > > On Fri, Jul 17, 2026 at 12:28:07PM +0000, [email protected] wrote:
> > > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > > > - [Low] Introduction of the legacy, non-standard `interface-pix-fmt` property for a standard hardware concept (parallel bus width), violating modern DT principles.
> > > > --
> > > >
> > > > --- Patch [1]: [PATCH v1 1/4] dt-bindings: lcdif: Add interface pixel format ---
> > > > commit 7225ea545d2ff50540972dd75d375b8ecea4f315
> > > > Author: Francesco Dolcini <[email protected]>
> > > >
> > > > dt-bindings: lcdif: Add interface pixel format
> > > >
> > > > This commit updates the fsl,lcdif device tree binding to support the
> > > > interface-pix-fmt property. The property is used to describe the hardware's
> > > > parallel data bus transfer width to match board wiring and prevent shifted
> > > > colors.
> > > >
> > > > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > > > > index 2dd0411ec6516..209ee5a96e393 100644
> > > > > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > > > > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > > > > @@ -58,6 +58,13 @@ properties:
> > > > >      items:
> > > > >        - const: rx
> > > > >
> > > > > +  interface-pix-fmt:
> > > > > +    $ref: /schemas/types.yaml#/definitions/string
> > > > > +    enum:
> > > > > +      - rgb24
> > > > > +      - rgb565
> > > > > +      - rgb666
> > > >
> > > > [Severity: Low]
> > > > Is this introducing a legacy, non-standard property into the new schema ABI?
> > > >
> > > > Standard devicetree guidelines usually prefer endpoint properties like
> > > > bus-width (defined in video-interfaces.yaml) to describe physical parallel
> > > > data line configurations, such as setting bus-width = <18> for RGB666.
> > > 
> > > Make sense, can we use standard property?
> > 
> > video-interfaces.yaml is for video capture interfaces (cameras and the
> > media/v4l subsystem). It does not apply here for DPI display interfaces.
> 
> ok, looking at this closer, it seems this is a used property also in the
> DRM subsystem. I'll appreciate a feedback from some DT maintainer before
> reworking this patch accordingly.

I reject any custom properties for describing the format of the parallel 
interface. 

Rob