Re: [PATCH v2 2/4] arm64: dts: imx952-evk: Add CM7 node and related memory nodes

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The vdev buffer memory region bypasses the name check in `imx_rproc_prepare()`, causing it to be incorrectly mapped as a general carveout.
--

--- Patch [2]: [PATCH v2 2/4] arm64: dts: imx952-evk: Add CM7 node and related memory nodes ---
commit 22a3bbe540374b7f9198ab38657f1b8b84d70816
Author: Peng Fan <[email protected]>

arm64: dts: imx952-evk: Add CM7 node and related memory nodes

This commit adds the remoteproc CM7 node and reserved memory regions for the
Cortex-M7 remote processor. The reserved memory includes firmware memory,
vring buffers, and a resource table.

> diff --git a/arch/arm64/boot/dts/freescale/imx952-evk.dts b/arch/arm64/boot/dts/freescale/imx952-evk.dts
> index 62d1c1c7c5013..fec851544fb11 100644
> --- a/arch/arm64/boot/dts/freescale/imx952-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx952-evk.dts
[ ... ]
> @@ -82,6 +82,42 @@ linux_cma: linux,cma {
[ ... ]
> +		vdev1vring1: vdev1vring1@88018000 {
> +			reg = <0 0x88018000 0 0x8000>;
> +			no-map;
> +		};
> +
> +		vdevbuffer: vdevbuffer@88020000 {

[Severity: Medium]
Should this node be named vdev0buffer instead of vdevbuffer?

Because this node is named vdevbuffer, it bypasses the driver's hardcoded
skip check strstarts(res.name, "vdev0buffer") in imx_rproc_prepare().

Will this cause the memory region to be incorrectly mapped as a general
carveout during rproc_start()?

This unnecessarily consumes 1MB of vmalloc space via ioremap_wc and
double-maps the memory since it is simultaneously initialized as a DMA
coherent pool.

> +			compatible = "shared-dma-pool";
> +			reg = <0 0x88020000 0 0x100000>;
> +			no-map;
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2