Re: [PATCH v3 05/11] nvmem: imx-ocotp-ele: Remove device-specific reg_read()

On Thu, Jul 23, 2026 at 09:27:27AM +0200, Frieder Schrempf wrote:
> From: Frieder Schrempf <[email protected]>
>
> We only have a single implementation of the read hook. There is no
> need to store it in the device data.

Remove .reg_read() callback in the device data because all is the same
implementation.

Frank

>
> Signed-off-by: Frieder Schrempf <[email protected]>
> ---
>  drivers/nvmem/imx-ocotp-ele.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/nvmem/imx-ocotp-ele.c b/drivers/nvmem/imx-ocotp-ele.c
> index dadec19ca252..9d3f94e35508 100644
> --- a/drivers/nvmem/imx-ocotp-ele.c
> +++ b/drivers/nvmem/imx-ocotp-ele.c
> @@ -33,7 +33,6 @@ struct ocotp_devtype_data {
>  	u32 size;
>  	u32 num_entry;
>  	u32 flag;
> -	nvmem_reg_read_t reg_read;
>  	const struct nvmem_keepout *keepout;
>  	unsigned int nkeepout;
>  	struct ocotp_map_entry entry[];
> @@ -158,7 +157,7 @@ static int imx_ele_ocotp_probe(struct platform_device *pdev)
>  	priv->config.id = NVMEM_DEVID_AUTO;
>  	priv->config.owner = THIS_MODULE;
>  	priv->config.size = priv->data->size;
> -	priv->config.reg_read = priv->data->reg_read;
> +	priv->config.reg_read = imx_ocotp_reg_read;
>  	priv->config.word_size = 1;
>  	priv->config.stride = 1;
>  	priv->config.priv = priv;
> @@ -190,7 +189,6 @@ static const struct nvmem_keepout imx93_ocotp_keepout[] = {
>
>  static const struct ocotp_devtype_data imx93_ocotp_data = {
>  	.reg_off = 0x8000,
> -	.reg_read = imx_ocotp_reg_read,
>  	.size = 2048,
>  	.num_entry = 6,
>  	.entry = {
> @@ -207,7 +205,6 @@ static const struct ocotp_devtype_data imx93_ocotp_data = {
>
>  static const struct ocotp_devtype_data imx94_ocotp_data = {
>  	.reg_off = 0x8000,
> -	.reg_read = imx_ocotp_reg_read,
>  	.size = 3296, /* 103 Banks */
>  	.num_entry = 10,
>  	.entry = {
> @@ -226,7 +223,6 @@ static const struct ocotp_devtype_data imx94_ocotp_data = {
>
>  static const struct ocotp_devtype_data imx95_ocotp_data = {
>  	.reg_off = 0x8000,
> -	.reg_read = imx_ocotp_reg_read,
>  	.size = 2048,
>  	.num_entry = 12,
>  	.entry = {
>
> --
> 2.55.0
>
>