Re: [PATCH v30 1/7] Documentation/firmware: add imx/se to other_interfaces
| Newsgroups | dev.linux.lists.imx,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The patch adds a `kernel-doc` directive for a file (`drivers/firmware/imx/se_ctrl.c`) that does not exist in the source tree. -- --- Patch [1]: [PATCH v30 1/7] Documentation/firmware: add imx/se to other_interfaces --- commit 43e18a35856ddc18eb46afd1a11d10f39aa86e8d Author: Pankaj Gupta <[email protected]> Documentation/firmware: add imx/se to other_interfaces Documents i.MX SoC's Service layer and C_DEV driver for selected SoCs that contain NXP hardware IPs for Secure Enclaves. > diff --git a/Documentation/driver-api/firmware/other_interfaces.rst b/Documentation/driver-api/firmware/other_interfaces.rst > index 06ac89adaafba..6c6fa9a0ba1df 100644 > --- a/Documentation/driver-api/firmware/other_interfaces.rst > +++ b/Documentation/driver-api/firmware/other_interfaces.rst > @@ -49,3 +49,136 @@ of the requests on to a secure monitor (EL3). [ ... ] > +When a user sends a command to the firmware, it registers its device_ctx > +as waiter of a response from firmware. > + > +Enclave's Firmware owns the storage management over a Linux filesystem. > +For this c_dev provisions a dedicated slave device called "receiver". > + > +.. kernel-doc:: drivers/firmware/imx/se_ctrl.c > + :export: [Severity: Low] Does this source file exist in the tree yet? It appears drivers/firmware/imx/se_ctrl.c is missing from this patch series, which will cause documentation builds to fail or emit warnings when trying to extract the kernel-doc comments. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1