Re: [PATCH v1 07/20] gpio: Add missing OF module annotations

On Tue, Jul 14, 2026 at 09:24:08AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> A driver module matching devices using an of device id table is supposed
> to declare that in the module's metadata. Add this information for
> several drivers that failed to declare these.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]>
> ---

Reviewed-by: Frank Li <[email protected]>

>  drivers/gpio/gpio-bcm-kona.c    | 1 +
>  drivers/gpio/gpio-creg-snps.c   | 1 +
>  drivers/gpio/gpio-ep93xx.c      | 1 +
>  drivers/gpio/gpio-ftgpio010.c   | 1 +
>  drivers/gpio/gpio-imx-scu.c     | 1 +
>  drivers/gpio/gpio-ixp4xx.c      | 2 +-
>  drivers/gpio/gpio-mpc5200.c     | 1 +
>  drivers/gpio/gpio-mpc8xxx.c     | 1 +
>  drivers/gpio/gpio-mpfs.c        | 1 +
>  drivers/gpio/gpio-msc313.c      | 1 +
>  drivers/gpio/gpio-mvebu.c       | 1 +
>  drivers/gpio/gpio-nomadik.c     | 1 +
>  drivers/gpio/gpio-pxa.c         | 1 +
>  drivers/gpio/gpio-spear-spics.c | 1 +
>  drivers/gpio/gpio-xgene.c       | 1 +
>  drivers/gpio/gpio-zevio.c       | 1 +
>  16 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
> index b0beffe48b7d..9bcbee25f685 100644
> --- a/drivers/gpio/gpio-bcm-kona.c
> +++ b/drivers/gpio/gpio-bcm-kona.c
> @@ -522,6 +522,7 @@ static struct of_device_id const bcm_kona_gpio_of_match[] = {
>  	{ .compatible = "brcm,kona-gpio" },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, bcm_kona_gpio_of_match);
>
>  /*
>   * This lock class tells lockdep that GPIO irqs are in a different
> diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
> index 157ab90f5ba8..2e159ea41791 100644
> --- a/drivers/gpio/gpio-creg-snps.c
> +++ b/drivers/gpio/gpio-creg-snps.c
> @@ -131,6 +131,7 @@ static const struct of_device_id creg_gpio_ids[] = {
>  		.data = &hsdk_cs_ctl
>  	}, { /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, creg_gpio_ids);
>
>  static int creg_gpio_probe(struct platform_device *pdev)
>  {
> diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
> index 8784e433e1ff..278b1093dd22 100644
> --- a/drivers/gpio/gpio-ep93xx.c
> +++ b/drivers/gpio/gpio-ep93xx.c
> @@ -377,6 +377,7 @@ static const struct of_device_id ep93xx_gpio_match[] = {
>  	{ .compatible = "cirrus,ep9301-gpio" },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, ep93xx_gpio_match);
>
>  static struct platform_driver ep93xx_gpio_driver = {
>  	.driver		= {
> diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
> index 11e6907c3b54..e29df8d5e571 100644
> --- a/drivers/gpio/gpio-ftgpio010.c
> +++ b/drivers/gpio/gpio-ftgpio010.c
> @@ -323,6 +323,7 @@ static const struct of_device_id ftgpio_gpio_of_match[] = {
>  	},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, ftgpio_gpio_of_match);
>
>  static struct platform_driver ftgpio_gpio_driver = {
>  	.driver = {
> diff --git a/drivers/gpio/gpio-imx-scu.c b/drivers/gpio/gpio-imx-scu.c
> index 0a75afecf9f8..3ebd3d73ed58 100644
> --- a/drivers/gpio/gpio-imx-scu.c
> +++ b/drivers/gpio/gpio-imx-scu.c
> @@ -114,6 +114,7 @@ static const struct of_device_id imx_scu_gpio_dt_ids[] = {
>  	{ .compatible = "fsl,imx8qxp-sc-gpio" },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, imx_scu_gpio_dt_ids);
>
>  static struct platform_driver imx_scu_gpio_driver = {
>  	.driver	= {
> diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
> index 669b139cd499..88d48cfc9017 100644
> --- a/drivers/gpio/gpio-ixp4xx.c
> +++ b/drivers/gpio/gpio-ixp4xx.c
> @@ -341,7 +341,7 @@ static const struct of_device_id ixp4xx_gpio_of_match[] = {
>  	},
>  	{},
>  };
> -
> +MODULE_DEVICE_TABLE(of, ixp4xx_gpio_of_match);
>
>  static struct platform_driver ixp4xx_gpio_driver = {
>  	.driver = {
> diff --git a/drivers/gpio/gpio-mpc5200.c b/drivers/gpio/gpio-mpc5200.c
> index 00f209157fd0..2c828bc922ae 100644
> --- a/drivers/gpio/gpio-mpc5200.c
> +++ b/drivers/gpio/gpio-mpc5200.c
> @@ -180,6 +180,7 @@ static const struct of_device_id mpc52xx_wkup_gpiochip_match[] = {
>  	{ .compatible = "fsl,mpc5200-gpio-wkup", },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, mpc52xx_wkup_gpiochip_match);
>
>  static struct platform_driver mpc52xx_wkup_gpiochip_driver = {
>  	.driver = {
> diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
> index a6868f673831..ee35da06cbc7 100644
> --- a/drivers/gpio/gpio-mpc8xxx.c
> +++ b/drivers/gpio/gpio-mpc8xxx.c
> @@ -318,6 +318,7 @@ static const struct of_device_id mpc8xxx_gpio_ids[] = {
>  	{ .compatible = "fsl,qoriq-gpio",   },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, mpc8xxx_gpio_ids);
>
>  static int mpc8xxx_probe(struct platform_device *pdev)
>  {
> diff --git a/drivers/gpio/gpio-mpfs.c b/drivers/gpio/gpio-mpfs.c
> index 7f0751d7b1c4..1078b3018970 100644
> --- a/drivers/gpio/gpio-mpfs.c
> +++ b/drivers/gpio/gpio-mpfs.c
> @@ -295,6 +295,7 @@ static const struct of_device_id mpfs_gpio_of_ids[] = {
>  	},
>  	{ /* end of list */ }
>  };
> +MODULE_DEVICE_TABLE(of, mpfs_gpio_of_ids);
>
>  static struct platform_driver mpfs_gpio_driver = {
>  	.probe = mpfs_gpio_probe,
> diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c
> index 7345afdc78de..38932986dc36 100644
> --- a/drivers/gpio/gpio-msc313.c
> +++ b/drivers/gpio/gpio-msc313.c
> @@ -688,6 +688,7 @@ static const struct of_device_id msc313_gpio_of_match[] = {
>  #endif
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, msc313_gpio_of_match);
>
>  /*
>   * The GPIO controller loses the state of the registers when the
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index 8d3acadb0d68..4d1625be11ec 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -978,6 +978,7 @@ static const struct of_device_id mvebu_gpio_of_match[] = {
>  		/* sentinel */
>  	},
>  };
> +MODULE_DEVICE_TABLE(of, mvebu_gpio_of_match);
>
>  static int mvebu_gpio_suspend(struct platform_device *pdev, pm_message_t state)
>  {
> diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c
> index 208fed631975..90293329b40b 100644
> --- a/drivers/gpio/gpio-nomadik.c
> +++ b/drivers/gpio/gpio-nomadik.c
> @@ -719,6 +719,7 @@ static const struct of_device_id nmk_gpio_match[] = {
>  	{ .compatible = "mobileye,eyeq5-gpio", },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, nmk_gpio_match);
>
>  static struct platform_driver nmk_gpio_driver = {
>  	.driver = {
> diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
> index 5d61053e0596..317e3bc925eb 100644
> --- a/drivers/gpio/gpio-pxa.c
> +++ b/drivers/gpio/gpio-pxa.c
> @@ -583,6 +583,7 @@ static const struct of_device_id pxa_gpio_dt_ids[] = {
>  	{ .compatible = "marvell,pxa1928-gpio",	.data = &pxa1928_id, },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, pxa_gpio_dt_ids);
>
>  static int pxa_gpio_probe_dt(struct platform_device *pdev,
>  			     struct pxa_gpio_chip *pchip)
> diff --git a/drivers/gpio/gpio-spear-spics.c b/drivers/gpio/gpio-spear-spics.c
> index 96a0e1211500..3099deb2b290 100644
> --- a/drivers/gpio/gpio-spear-spics.c
> +++ b/drivers/gpio/gpio-spear-spics.c
> @@ -157,6 +157,7 @@ static const struct of_device_id spics_gpio_of_match[] = {
>  	{ .compatible = "st,spear-spics-gpio" },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, spics_gpio_of_match);
>
>  static struct platform_driver spics_gpio_driver = {
>  	.probe = spics_gpio_probe,
> diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c
> index ad0f1551c271..b34b0c58b67c 100644
> --- a/drivers/gpio/gpio-xgene.c
> +++ b/drivers/gpio/gpio-xgene.c
> @@ -191,6 +191,7 @@ static const struct of_device_id xgene_gpio_of_match[] = {
>  	{ .compatible = "apm,xgene-gpio", },
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, xgene_gpio_of_match);
>
>  #ifdef CONFIG_ACPI
>  static const struct acpi_device_id xgene_gpio_acpi_match[] = {
> diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
> index 288a86c8294a..f1c5c6a20673 100644
> --- a/drivers/gpio/gpio-zevio.c
> +++ b/drivers/gpio/gpio-zevio.c
> @@ -213,6 +213,7 @@ static const struct of_device_id zevio_gpio_of_match[] = {
>  	{ .compatible = "lsi,zevio-gpio", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, zevio_gpio_of_match);
>
>  static struct platform_driver zevio_gpio_driver = {
>  	.driver		= {
> --
> 2.55.0.11.g153666a7d9bb
>
>