Re: [PATCH] spi: fsl-lpspi: replace dmaengine_terminate_all with dmaengine_terminate_sync
Frank Li <[email protected]>
| Newsgroups | dev.linux.lists.imx,org.kernel.vger.linux-kernel,org.kernel.vger.linux-spi,org.kernel.vger.stable |
|---|---|
| Message-ID | <amO-PzRgr1WMWrDA@lizhi-Precision-Tower-5810> |
On Tue, May 19, 2026 at 06:45:17PM +0800, Carlos Song (OSS) wrote: > From: Carlos Song <[email protected]> > > The terminate API dmaengine_terminate_all() has been deprecated, improve > driver with dmaengine_terminate_sync(). > > Fixes: 09c04466ce7e ("spi: lpspi: add dma mode support") > Cc: [email protected] > Signed-off-by: Carlos Song <[email protected]> > --- Reviewed-by: Frank Li <[email protected]> > drivers/spi/spi-fsl-lpspi.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c > index e201309f8aae..1a94a42fac31 100644 > --- a/drivers/spi/spi-fsl-lpspi.c > +++ b/drivers/spi/spi-fsl-lpspi.c > @@ -647,7 +647,7 @@ static int fsl_lpspi_dma_transfer(struct spi_controller *controller, > tx->sgl, tx->nents, DMA_MEM_TO_DEV, > DMA_PREP_INTERRUPT | DMA_CTRL_ACK); > if (!desc_tx) { > - dmaengine_terminate_all(controller->dma_tx); > + dmaengine_terminate_sync(controller->dma_tx); > return -EINVAL; > } > > @@ -668,8 +668,8 @@ static int fsl_lpspi_dma_transfer(struct spi_controller *controller, > transfer_timeout); > if (!time_left) { > dev_err(fsl_lpspi->dev, "I/O Error in DMA TX\n"); > - dmaengine_terminate_all(controller->dma_tx); > - dmaengine_terminate_all(controller->dma_rx); > + dmaengine_terminate_sync(controller->dma_tx); > + dmaengine_terminate_sync(controller->dma_rx); > fsl_lpspi_reset(fsl_lpspi); > return -ETIMEDOUT; > } > @@ -678,8 +678,8 @@ static int fsl_lpspi_dma_transfer(struct spi_controller *controller, > transfer_timeout); > if (!time_left) { > dev_err(fsl_lpspi->dev, "I/O Error in DMA RX\n"); > - dmaengine_terminate_all(controller->dma_tx); > - dmaengine_terminate_all(controller->dma_rx); > + dmaengine_terminate_sync(controller->dma_tx); > + dmaengine_terminate_sync(controller->dma_rx); > fsl_lpspi_reset(fsl_lpspi); > return -ETIMEDOUT; > } > @@ -688,8 +688,8 @@ static int fsl_lpspi_dma_transfer(struct spi_controller *controller, > fsl_lpspi->target_aborted) { > dev_dbg(fsl_lpspi->dev, > "I/O Error in DMA TX interrupted\n"); > - dmaengine_terminate_all(controller->dma_tx); > - dmaengine_terminate_all(controller->dma_rx); > + dmaengine_terminate_sync(controller->dma_tx); > + dmaengine_terminate_sync(controller->dma_rx); > fsl_lpspi_reset(fsl_lpspi); > return -EINTR; > } > @@ -698,8 +698,8 @@ static int fsl_lpspi_dma_transfer(struct spi_controller *controller, > fsl_lpspi->target_aborted) { > dev_dbg(fsl_lpspi->dev, > "I/O Error in DMA RX interrupted\n"); > - dmaengine_terminate_all(controller->dma_tx); > - dmaengine_terminate_all(controller->dma_rx); > + dmaengine_terminate_sync(controller->dma_tx); > + dmaengine_terminate_sync(controller->dma_rx); > fsl_lpspi_reset(fsl_lpspi); > return -EINTR; > } > -- > 2.43.0 >