Re: [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure
Herbert Xu <[email protected]>
| Newsgroups | dev.linux.lists.imx,dev.linux.lists.linux-sunxi,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-crypto,org.kernel.vger.linux-kernel,org.ozlabs.lists.linux-aspeed |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Jul 17, 2026 at 04:00:14PM +0800, Pan Chuang wrote:
> Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()") added automatic error logging to
> devm_request_threaded_irq() and devm_request_any_context_irq()
> via the new devm_request_result() helper, which prints device
> name, IRQ number, handler functions, and error code on failure.
>
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this
> automatic logging.
>
> Remove the now-redundant dev_err() and dev_err_probe() calls
> in crypto drivers that follow these devm_request_*_irq()
> functions, as the core now provides more detailed diagnostic
> information on failure.
>
> Pan Chuang (12):
> crypto: allwinner - Remove redundant dev_err()
> crypto: amlogic - Remove redundant dev_err()
> crypto: aspeed - Remove redundant dev_err()
> crypto: Remove redundant dev_err()/dev_err_probe()
> crypto: caam - Remove redundant dev_err()
> crypto: ccree - Remove redundant dev_err()
> crypto: sl3516 - Remove redundant dev_err()
> crypto: safexcel - Remove redundant dev_err()
> crypto: keembay - Remove redundant dev_err()
> crypto: octeontx2 - Remove redundant dev_err()
> crypto: rockchip - Remove redundant dev_err()
> crypto: stm32 - Remove redundant dev_err()
>
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 4 +---
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +---
> drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +---
> drivers/crypto/aspeed/aspeed-acry.c | 4 +---
> drivers/crypto/aspeed/aspeed-hace.c | 4 +---
> drivers/crypto/atmel-aes.c | 4 +---
> drivers/crypto/atmel-sha.c | 4 +---
> drivers/crypto/atmel-tdes.c | 4 +---
> drivers/crypto/caam/jr.c | 2 --
> drivers/crypto/ccree/cc_driver.c | 4 +---
> drivers/crypto/gemini/sl3516-ce-core.c | 4 +---
> drivers/crypto/img-hash.c | 4 +---
> drivers/crypto/inside-secure/safexcel.c | 4 +---
> drivers/crypto/intel/keembay/keembay-ocs-aes-core.c | 4 +---
> drivers/crypto/intel/keembay/keembay-ocs-ecc.c | 4 +---
> drivers/crypto/intel/keembay/keembay-ocs-hcu-core.c | 4 +---
> drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c | 5 +----
> drivers/crypto/mxs-dcp.c | 8 ++------
> drivers/crypto/omap-aes.c | 4 +---
> drivers/crypto/omap-des.c | 4 +---
> drivers/crypto/omap-sham.c | 5 +----
> drivers/crypto/rockchip/rk3288_crypto.c | 4 +---
> drivers/crypto/sahara.c | 3 +--
> drivers/crypto/stm32/stm32-cryp.c | 4 +---
> drivers/crypto/stm32/stm32-hash.c | 4 +---
> 25 files changed, 25 insertions(+), 78 deletions(-)
>
> --
> 2.34.1
All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt