Re: [PATCH v5 5/5] arm64: dts: imx8mp-skov: support new 7inch panel board

Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [High] The touch controller node is missing from the device tree overlay, despite the commit message explicitly claiming support for a new touch controller.
- [High] The `lcdif2` display controller is not enabled, which will prevent the display pipeline from working.
- [Low] Missing `#address-cells` and `#size-cells` properties in the `ports` node of the overlay causes a dtc compiler warning.
- [Low] The closing brace for the `ports` node is indented with spaces instead of tabs.
--

--- Patch [5]: [PATCH v5 5/5] arm64: dts: imx8mp-skov: support new 7inch panel board ---
commit ad8d9c520b6e230240af8bd68c3a85a7288fc73b
Author: Steffen Trumtrar <[email protected]>

arm64: dts: imx8mp-skov: support new 7inch panel board

This commit adds a device tree overlay to support the SKOV IMX8MP CPU revC
board with a JuTouch JT070TM041 7-inch panel. The commit message notes
that the board uses a different panel with a different touch controller.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dtso b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dtso
> new file mode 100644
> index 0000000000000..2433b57aeed40
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dtso
> @@ -0,0 +1,36 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&{/} {

[Severity: High]
The commit message mentions support for a new touch controller, but there
doesn't seem to be a touch controller node defined on any I2C bus in this
overlay. Will the touchscreen hardware fail to initialize without this node?

Also, is it necessary to enable the display controller here? It appears
that without a node like &lcdif2 { status = "okay"; }; the display pipeline
might fail to probe because it remains disabled in the base device tree,
which could leave the panel blank.

> +	model = "SKOV IMX8MP CPU revC - JuTouch JT070TM041";
> +	compatible = "skov,imx8mp-skov-revc-jutouch-jt070tm041", "fsl,imx8mp";
> +
> +	panel {
> +		compatible = "jutouch,jt070tm041";

[ ... ]

> +&lvds_bridge {
> +	/* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_DISP2_PIX * 7 */
> +	assigned-clock-rates = <0>, <358400000>;
> +
> +	ports {

[Severity: Low]
Does this ports node need explicit #address-cells = <1>; and
#size-cells = <0>; properties? Without them, compiling this overlay
independently could cause dtc to emit warnings about invalid property
lengths for port@1 since it assumes the default #address-cells = 2.

> +		port@1 {
> +			reg = <1>;
> +
> +			ldb_lvds_ch0: endpoint {
> +				remote-endpoint = <&in_lvds0>;
> +			};
> +		};
> +        };

[Severity: Low]
This isn't a bug, but this closing brace is indented with spaces instead
of standard tabs.

> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-v7-0-topic-imx8mp-skov-dts-jutouch-7inch-v5-0-67faa5ee0bf6@pengutronix.de?part=5