Re: [PATCH v7 5/5] arm64: dts: imx8mp-skov: support new 7inch panel board

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] Missing device tree binding includes causes build failure.
- [High] Incorrect touchscreen resolution properties (copy-paste logic error).
- [Medium] Missing #address-cells and #size-cells in &i2c2 node causes compilation warnings.
--

--- Patch [5]: [PATCH v7 5/5] arm64: dts: imx8mp-skov: support new 7inch panel board ---
commit 5301893644854d4544c31ab94b72a17eda53338e
Author: Steffen Trumtrar <[email protected]>

arm64: dts: imx8mp-skov: support new 7inch panel board
    
This board is similar to the already upstream
imx8mp-skov-revc-tian-g07017 and imx8mp-skov-revc-jt101tm023 but uses a
different 7" panel with a different touch controller.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dtso b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dtso
> new file mode 100644
> index 0000000000000..f3f43e60a0aa7
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dtso
> @@ -0,0 +1,53 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +
> +/dts-v1/;
> +/plugin/;

[Severity: High]
Does this overlay need dt-bindings includes? The C preprocessor won't expand
IRQ_TYPE_LEVEL_LOW and GPIO_ACTIVE_LOW without
<dt-bindings/interrupt-controller/irq.h> and <dt-bindings/gpio/gpio.h>,
which will cause a syntax error during device tree compilation.

[ ... ]

> +&i2c2 {

[Severity: Medium]
Will this parent node cause dtc warnings during overlay compilation? Since
overlays are compiled in isolation, dtc will fall back to default
#address-cells and #size-cells values, which conflict with the 1-cell reg
property of the child node. Should it explicitly define #address-cells = <1>;
and #size-cells = <0>;?

> +	touchscreen@2a {
> +		compatible = "eeti,exc81w32", "eeti,exc80h84";
> +		reg = <0x2a>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_touchscreen>;
> +		interrupts-extended = <&gpio4 28 IRQ_TYPE_LEVEL_LOW>;
> +		reset-gpios = <&gpio4 29 GPIO_ACTIVE_LOW>;
> +		touchscreen-size-x = <1280>;
> +		touchscreen-size-y = <800>;

[Severity: High]
Are these resolution properties correct for this panel? The jutouch,jt070tm041
7" panel has a native resolution of 1024x600. Setting the maximums to 1280x800
will cause miscalibration in userspace, where the touch pointer won't be able
to reach the edges of the screen.

> +		vdd-supply = <&reg_vdd_3v3>;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-v7-0-topic-imx8mp-skov-dts-jutouch-7inch-v7-0-ca8a0446166a@pengutronix.de?part=5