Re: [PATCH v6 3/7] arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Chaining overlays in a multi-dtb rule fails at build time because preceding overlays do not export `__symbols__` for subsequent overlays to resolve their `__fixups__`.
--

--- Patch [3]: [PATCH v6 3/7] arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC ---
commit 68e606cc871d4844f2966698d1f9194823c8f933
Author: Marek Vasut <[email protected]>

arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC

This patch adds legacy board revision compatibility DT overlays for both
i.MX8M Mini and Plus eDM SBC boards. It includes adjustments to support
these legacy board revisions.

> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 9da078bb6380b..c3de54507aae0 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
[ ... ]
> @@ -344,6 +350,24 @@ imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-mi1010z1t-1cp11-dtbs := \
>  	imx8mp-data-modul-edm-sbc.dtb \
>  	imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-mi1010z1t-1cp11.dtbo
>  
> +imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900-dtbs := \
> +	imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-rev900.dtb \
> +	imx8mp-data-modul-edm-sbc-overlay-edm-mod-imx8mm-lvds-g070y2-l01.dtbo \
> +	imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900.dtbo

[Severity: Low]
Does this multi-dtb rule cause an fdtoverlay failure at build time?

Because the Kbuild system compiles .dtbo files without the -@ flag unless
explicitly requested, the first overlay (...lvds-g070y2-l01.dtbo) does not
export __symbols__ for the subsequent overlay (...lvds-rev900.dtbo) to resolve
its __fixups__ against.

[ ... ]
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900.dtso b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900.dtso
> new file mode 100644
> index 0000000000000..427585b78e45d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900.dtso
[ ... ]
> +&reg_panel_bl_supply {
> +	status = "disabled";
> +};

[Severity: Low]
Will this label reference fail to resolve during the build since it relies
on the preceding overlay in the chain which does not have symbols enabled?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3