Re: [PATCH v5 1/4] media: nxp: imx8-isi: Use BIT_ULL() for 64-bit stream masks

On Tue, Jul 28, 2026 at 8:55 AM Guoniu Zhou <[email protected]> wrote:
>
> Use BIT_ULL() instead of BIT() for u64 stream masks to avoid incorrect
> results on 32-bit architectures when stream IDs are 32 or greater.
>
> Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")
> Cc: [email protected]
> Signed-off-by: Guoniu Zhou <[email protected]>

Reviewed-by: Loic Poulain <[email protected]>

> ---
>  drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> index 9f0231ca47a3..9db9c6e55c2c 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> @@ -157,10 +157,10 @@ mxc_isi_crossbar_xlate_streams(struct mxc_isi_crossbar *xbar,
>          */
>         for_each_active_route(&state->routing, route) {
>                 if (route->source_pad != source_pad ||
> -                   !(source_streams & BIT(route->source_stream)))
> +                   !(source_streams & BIT_ULL(route->source_stream)))
>                         continue;
>
> -               sink_streams |= BIT(route->sink_stream);
> +               sink_streams |= BIT_ULL(route->sink_stream);
>                 sink_pad = route->sink_pad;
>         }
>
>
> --
> 2.34.1
>