Re: [PATCH v2 06/12] arm64: dts: imx8ulp-evk: fix reserved memory node names for remoteproc

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Medium] Incomplete fix: The patch resolves a bug where the vdev buffer is unnecessarily mapped by renaming the device tree node from `vdevbuffer` to `vdev0buffer`. However, this renaming was only applied to a subset of i.MX8 device trees, leaving the exact same bug unresolved in numerous other Freescale device trees (e.g., i.MX93, i.MX8MM).
--

--- Patch [6]: [PATCH v2 06/12] arm64: dts: imx8ulp-evk: fix reserved memory node names for remoteproc ---
commit 1515907215de5459529c9efcc4af91b85ac7ba38
Author: Peng Fan <[email protected]>

arm64: dts: imx8ulp-evk: fix reserved memory node names for remoteproc

This commit renames the vdevbuffer node to vdev0buffer in the imx8ulp-evk
device tree. This prevents the imx_rproc driver from unnecessarily mapping
the vdev buffer region during initialization.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> index 5dea66c1e7aa0..48a3e40053299 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> @@ -67,7 +67,7 @@ vdev1vring1: vdev1vring1@aff18000 {
>  			no-map;
>  		};
>  
> -		vdevbuffer: vdevbuffer@a8400000 {
> +		vdev0buffer: vdev0buffer@a8400000 {

[Severity: Medium]
This is a pre-existing issue, but this patch only partially fixes the problem.

There are other Freescale device trees that still define the node as
vdevbuffer, which will continue to trigger the unnecessary mapping in
imx_rproc_prepare(). For example:

arch/arm64/boot/dts/freescale/imx93-11x11-evk-common.dtsi:
    vdevbuffer: vdevbuffer@a4020000 {

arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso:
    vdevbuffer: vdevbuffer@b8400000 {

The driver uses a hardcoded string check:

drivers/remoteproc/imx_rproc.c:imx_rproc_prepare() {
    ...
    if (strstarts(res.name, "vdev0buffer"))
        continue;
    ...
}

Should the nodes in the other affected device trees also be renamed, or could
the driver check be updated to handle both names to prevent this issue across
all boards?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6