Re: [PATCH v2 10/12] arm64: dts: imx8dxl-sr-som: fix reserved memory node names for remoteproc

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch replaces generic Device Tree node names with non-generic, specific names (e.g., `vdev0vring0@90000000`) to satisfy hardcoded string matching in the `imx_rproc` driver. This violates the DT specification rule that node names should be generic.
--

--- Patch [10]: [PATCH v2 10/12] arm64: dts: imx8dxl-sr-som: fix reserved memory node names for remoteproc ---
commit 1d32457a00ef15e201f5eccc0be6be161bf05b59
Author: Peng Fan <[email protected]>

arm64: dts: imx8dxl-sr-som: fix reserved memory node names for remoteproc

This patch renames reserved memory nodes in the device tree to use specific
names like vdev0vring0 to satisfy hardcoded string matches in the imx_rproc
driver.

> diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi
> --- a/arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi

[ ... ]

> @@ -103,32 +103,32 @@ linux,cma {
>  			linux,cma-default;
>  		};
>  
> -		vdev0vring0: memory0@90000000 {
> +		vdev0vring0: vdev0vring0@90000000 {

[Severity: Low]
Does replacing generic node names with driver-specific names violate the
Device Tree specification rule requiring generic node names?

The specification states that node names should be generic (e.g., memory@...)
and reflect the hardware class, not a specific driver or programming model.

Could the imx_rproc driver be updated to use the standard memory-region-names
property to identify these regions, rather than working around the driver's
expectations by introducing non-generic node names into the DTS?

>  			reg = <0 0x90000000 0 0x8000>;
>  			no-map;
>  		};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10