Re: [PATCH v32 1/7] Documentation/firmware: add imx/se to other_interfaces

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The documentation references a non-existent source file (`drivers/firmware/imx/se_ctrl.c`) using a `kernel-doc` directive, which will cause documentation build warnings or failures.
--

--- Patch [1]: [PATCH v32 1/7] Documentation/firmware: add imx/se to other_interfaces ---
commit 596e79c16cd58344a1eb725fe075ae129cefa874
Author: Pankaj Gupta <[email protected]>

Documentation/firmware: add imx/se to other_interfaces

This commit documents the i.MX SoC Service layer and character device driver
for hardware IPs like the NXP EdgeLock Enclave. It details the communication
interfaces, message serialization, and character device contexts used to
interact with the secure enclaves.

> diff --git a/Documentation/driver-api/firmware/other_interfaces.rst b/Documentation/driver-api/firmware/other_interfaces.rst
> --- a/Documentation/driver-api/firmware/other_interfaces.rst
> +++ b/Documentation/driver-api/firmware/other_interfaces.rst
[ ... ]
> @@ -49,3 +49,136 @@ of the requests on to a secure monitor (EL3).
[ ... ]
> +When a user sends a command to the firmware, it registers its device_ctx
> +as waiter of a response from firmware.
> +
> +Enclave's Firmware owns the storage management over a Linux filesystem.
> +For this c_dev provisions a dedicated slave device called "receiver".
> +
> +.. kernel-doc:: drivers/firmware/imx/se_ctrl.c
> +   :export:

[Severity: Low]
Does drivers/firmware/imx/se_ctrl.c exist in the tree at this commit? 

It looks like this kernel-doc directive references a file that is not
present, which might cause documentation build targets to fail or emit
warnings because Sphinx cannot locate it.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1