Re: [PATCH v32 6/7] arm64: dts: imx8ulp: add secure enclave node

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Devicetree Schema Violation for disabled secure-enclave node
--

--- Patch [6]: [PATCH v32 6/7] arm64: dts: imx8ulp: add secure enclave node ---
commit 9ea23a325f779943e0d6ff5ef6459ab8d6494416
Author: Pankaj Gupta <[email protected]>

arm64: dts: imx8ulp: add secure enclave node

This patch adds the EdgeLock Enclave (ELE) secure-enclave node to the
i.MX8ULP SoC dtsi. The node is kept disabled by default so it does not
impose a reserved-memory requirement on every board.

Closes: https://sashiko.dev/#/patchset/[email protected]?part=6

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index c6d1bb9edf388..38233dd74ee33 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi

[ ... ]

> @@ -185,6 +185,14 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +			status = "disabled";
> +		};

[Severity: Low]
Will this cause a devicetree schema validation warning during dtbs_check?

Because the dt-binding schema requires the 'memory-region' property for the 
"fsl,imx8ulp-se-ele-hsm" compatible string, omitting it here means any board 
that includes imx8ulp.dtsi without enabling the enclave will fail validation, 
even though the node is disabled. 

Could we avoid validation warnings by defining a dummy memory-region, or by 
restructuring how this node is included for boards that do not use the enclave?

>  	};
>  
>  	cm33: remoteproc-cm33 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6