RE: [PATCH v32 1/7] Documentation/firmware: add imx/se to other_interfaces

"Pankaj Gupta (OSS)" <[email protected]> Thu, 30 Jul 2026 10:55:13 +0000
Newsgroups dev.linux.lists.imx,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree
Message-ID <GV2PR04MB1227197DA7F11D88433507C7895C92@GV2PR04MB12271.eurprd04.prod.outlook.com>
> Documentation/firmware: add imx/se to other_interfaces
> 
> This commit documents the i.MX SoC Service layer and character device driver
> for hardware IPs like the NXP EdgeLock Enclave. It details the communication
> interfaces, message serialization, and character device contexts used to
> interact with the secure enclaves.
> 
> > diff --git a/Documentation/driver-api/firmware/other_interfaces.rst
> > b/Documentation/driver-api/firmware/other_interfaces.rst
> > --- a/Documentation/driver-api/firmware/other_interfaces.rst
> > +++ b/Documentation/driver-api/firmware/other_interfaces.rst
> [ ... ]
> > @@ -49,3 +49,136 @@ of the requests on to a secure monitor (EL3).
> [ ... ]
> > +When a user sends a command to the firmware, it registers its
> > +device_ctx as waiter of a response from firmware.
> > +
> > +Enclave's Firmware owns the storage management over a Linux filesystem.
> > +For this c_dev provisions a dedicated slave device called "receiver".
> > +
> > +.. kernel-doc:: drivers/firmware/imx/se_ctrl.c
> > +   :export:
> 
> [Severity: Low]
> Does drivers/firmware/imx/se_ctrl.c exist in the tree at this commit?
> 
While confirming this It is also to be noted that se_ctrl.c currently exposes no
EXPORT_SYMBOL*() symbols and no /** kernel-doc comment blocks as part of
this patch-set, so even once the file is present the `:export:` directive would pull in
nothing and Sphinx would report "no structured comments found".
Request you to ignore this finding till EXPORT_SYMBOL is added in future commits.

> It looks like this kernel-doc directive references a file that is not present, which
> might cause documentation build targets to fail or emit warnings because
> Sphinx cannot locate it.
>