[PATCH v2 3/3] usb: typec: Use %pe to print error pointers
Subasri S <[email protected]> Sat, 01 Aug 2026 17:59:52 +0530
| Newsgroups | dev.linux.lists.imx,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Use the %pe format specifier instead of %ld with PTR_ERR() for printing error pointers in various typec drivers. This prints symbolic error names (e.g.-ENOMEM) instead of errno numbers (e.g. -12), making error logs more readable. Fix coccinelle reported warning: WARNING: Consider using %pe to print PTR_ERR() Compile tested only. Reviewed-by: Badhri Jagan Sridharan <[email protected]> Signed-off-by: Subasri S <[email protected]> --- drivers/usb/typec/mux/pi3usb30532.c | 6 ++---- drivers/usb/typec/tcpm/tcpm.c | 2 +- drivers/usb/typec/wusb3801.c | 4 ++-- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c index 985683fe49e9..b32f4c433de9 100644 --- a/drivers/usb/typec/mux/pi3usb30532.c +++ b/drivers/usb/typec/mux/pi3usb30532.c @@ -139,8 +139,7 @@ static int pi3usb30532_probe(struct i2c_client *client) pi->sw = typec_switch_register(dev, &sw_desc); if (IS_ERR(pi->sw)) { - dev_err(dev, "Error registering typec switch: %ld\n", - PTR_ERR(pi->sw)); + dev_err(dev, "Error registering typec switch: %pe\n", pi->sw); return PTR_ERR(pi->sw); } @@ -151,8 +150,7 @@ static int pi3usb30532_probe(struct i2c_client *client) pi->mux = typec_mux_register(dev, &mux_desc); if (IS_ERR(pi->mux)) { typec_switch_unregister(pi->sw); - dev_err(dev, "Error registering typec mux: %ld\n", - PTR_ERR(pi->mux)); + dev_err(dev, "Error registering typec mux: %pe\n", pi->mux); return PTR_ERR(pi->mux); } diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 89eec20a2064..ad10470ea73b 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -4796,7 +4796,7 @@ static void tcpm_typec_connect(struct tcpm_port *port) port->partner_desc.accessory = TYPEC_ACCESSORY_NONE; partner = typec_register_partner(port->typec_port, &port->partner_desc); if (IS_ERR(partner)) { - dev_err(port->dev, "Failed to register partner (%ld)\n", PTR_ERR(partner)); + dev_err(port->dev, "Failed to register partner (%pe)\n", partner); return; } diff --git a/drivers/usb/typec/wusb3801.c b/drivers/usb/typec/wusb3801.c index 6062875fb04a..86d13ab41670 100644 --- a/drivers/usb/typec/wusb3801.c +++ b/drivers/usb/typec/wusb3801.c @@ -277,8 +277,8 @@ static void wusb3801_hw_update(struct wusb3801 *wusb3801) if (partner_type != WUSB3801_STAT_PARTNER_STANDBY) { wusb3801->partner = typec_register_partner(port, &desc); if (IS_ERR(wusb3801->partner)) - dev_err(dev, "Failed to register partner: %ld\n", - PTR_ERR(wusb3801->partner)); + dev_err(dev, "Failed to register partner: %pe\n", + wusb3801->partner); } data_role = pwr_role == TYPEC_SOURCE ? TYPEC_HOST : TYPEC_DEVICE; -- 2.43.0