Re: [EXT] Re: [PATCH v2 1/3] arm64: dts: imx93-11x11-frdm: factor out common parts into dtsi

On 7/23/2026 3:22 PM, [email protected] wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
> 
> 
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The patch contradicts its v2 changelog by moving the board-specific `lpuart5` pin assignments into the common `.dtsi` file instead of the board-specific `.dts`.
> --
> 
> --- Patch [1]: [PATCH v2 1/3] arm64: dts: imx93-11x11-frdm: factor out common parts into dtsi ---
> commit 35cb24d7221e1d0efbc151d7ebfd44422372ffdb
> Author: Joseph Guo <[email protected]>
> 
> arm64: dts: imx93-11x11-frdm: factor out common parts into dtsi
> 
> This commit extracts common hardware definitions from the i.MX93 FRDM board
> into a shared imx93-11x11-frdm-common.dtsi file to allow reuse by the Wireless
> FRDM board. The FRDM-IMX93 board-specific .dts is updated to include the
> common dtsi.
> 
>> ---
>> Changes in v2:
>> - Move board specific lpuart5 pin assignment to board dts.
>> - Move pcal6408 node to board dts
>> ---
>>  ...11x11-frdm.dts => imx93-11x11-frdm-common.dtsi} | 129 +---
>>  arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts | 679 +--------------------
>>  2 files changed, 7 insertions(+), 801 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-frdm-common.dtsi b/arch/arm64/boot/dts/freescale/imx93-11x11-frdm-common.dtsi
>> new file mode 100644
>> index 0000000000000..5c8fdd77ec15b
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-frdm-common.dtsi
> [ ... ]
>> +&lpuart5 {
>> +     pinctrl-0 = <&pinctrl_uart5>;
>> +     pinctrl-names = "default";
>> +     status = "okay";
> 
> [Severity: Medium]
> Does this contradict the v2 changelog?
> 
> The changelog states "Move board specific lpuart5 pin assignment to board
> dts", but the lpuart5 node and its pinctrl assignment are being added to the
> common imx93-11x11-frdm-common.dtsi file here.
> 

The pinctrl for uart5 is same on imx93w-frdm and imx93-11x11-frdm. The difference are the reset/wakeup gpio and vcc-supply.
> [ ... ]
>> +     pinctrl_uart5: uart5grp {
>> +             fsl,pins = <
>> +                     MX93_PAD_DAP_TDO_TRACESWO__LPUART5_TX           0x31e
>> +                     MX93_PAD_DAP_TDI__LPUART5_RX                    0x31e
>> +                     MX93_PAD_DAP_TMS_SWDIO__LPUART5_RTS_B           0x31e
>> +                     MX93_PAD_DAP_TCLK_SWCLK__LPUART5_CTS_B          0x31e
>> +             >;
>> +     };
> 
> [Severity: Medium]
> Similarly, the pinctrl_uart5 pinmux group definition is placed in the
> common file instead of the board-specific dts.
> 
> Could this incorrectly share board-specific pin muxing with other boards that
> include this dtsi?
> 
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1

-- 
Best Regards,
Joseph