Re: [PATCH v9 3/7] arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Disabling a supply node without removing the consumer's `vin-supply` reference causes infinite probe deferral.
--

--- Patch [3]: [PATCH v9 3/7] arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC ---
commit 38e183a549e432bbb19f97500f860bf54f6c111a
Author: Marek Vasut <[email protected]>

arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC

This commit adds legacy board revision compatibility DT overlays for both 
i.MX8M Mini and Plus eDM SBC boards. This adds adjustments to support 
legacy board revisions.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900.dtso b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900.dtso
> new file mode 100644
> index 0000000000000..427585b78e45d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900.dtso

[ ... ]

> +&reg_panel_bl_supply {
> +	status = "disabled";
> +};
> +
> +&reg_panel_bl {
> +	gpio = <&gpio3 0 0>;
> +};

[Severity: High]
Will this cause an infinite probe deferral for the backlight?

The supply node reg_panel_bl_supply is being disabled here, but the consumer 
node reg_panel_bl inherits vin-supply = <&reg_panel_bl_supply>; from the 
base DT. 

Because the status property is ignored during phandle parsing, the regulator
framework will find the target node but fail to find a registered device for 
it, returning a permanent -EPROBE_DEFER. 

Should this also remove the reference via /delete-property/ vin-supply; in 
reg_panel_bl?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3