Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing device tree binding update for 'qcom,shikra-camss' compatible string.
--
--- Patch [1]: [PATCH RESEND v6 1/5] arm64: dts: qcom: shikra: Add CAMSS node ---
commit 61ed442ae43c338e75ef6a64a39ccb1fc9e42714
Author: Nihal Kumar Gupta <[email protected]>
arm64: dts: qcom: shikra: Add CAMSS node
This commit adds the Camera Subsystem (CAMSS) node to the Shikra device tree.
It configures the registers, clocks, interrupts, interconnects, and other
properties for the camera IP, which is similar to QCM2290 but uses a single
IOMMU context bank.
> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -640,6 +640,106 @@ &clk_virt SLAVE_QUP_CORE_0 RPM_ALWAYS_TAG>,
> };
> };
>
> + camss: camss@5c11000 {
> + compatible = "qcom,shikra-camss", "qcom,qcm2290-camss";
[Severity: Low]
Is there a corresponding dt-binding update to allow this new compatible string?
Running dtbs_check will likely fail validation here because the schema for
the QCM2290 CAMSS expects exactly const: qcom,qcm2290-camss and does not
currently accept a list or the qcom,shikra-camss string.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.