Re: [PATCH v34 1/7] Documentation/firmware: add imx/se to other_interfaces
| Newsgroups | dev.linux.lists.imx,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The kernel-doc directive references a non-existent file 'drivers/firmware/imx/se_ctrl.c', which breaks documentation builds. -- --- Patch [1]: [PATCH v34 1/7] Documentation/firmware: add imx/se to other_interfaces --- commit 2a1a9962f9352382d58e5f7ad151d5b2fd1a395f Author: Pankaj Gupta <[email protected]> Documentation/firmware: add imx/se to other_interfaces Documents the i.MX SoC Service layer and C_DEV driver for selected SoCs containing NXP hardware IPs for Secure Enclaves. > diff --git a/Documentation/driver-api/firmware/other_interfaces.rst b/Documentation/driver-api/firmware/other_interfaces.rst > --- a/Documentation/driver-api/firmware/other_interfaces.rst > +++ b/Documentation/driver-api/firmware/other_interfaces.rst [ ... ] > +When a user sends a command to the firmware, it registers its device_ctx > +as waiter of a response from firmware. > + > +Enclave's Firmware owns the storage management over a Linux filesystem. > +For this c_dev provisions a dedicated slave device called "receiver". > + > +.. kernel-doc:: drivers/firmware/imx/se_ctrl.c > + :export: [Severity: Low] Does drivers/firmware/imx/se_ctrl.c exist in the source tree at this commit? It appears this directive references a file that is not present, which will cause warnings or failures during documentation builds. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1