Re: [PATCH v34 6/7] arm64: dts: imx8ulp: add secure enclave node

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing strictly required property `memory-region` in the disabled `secure-enclave` node will trigger `dt-validate` schema errors.
--

--- Patch [6]: [PATCH v34 6/7] arm64: dts: imx8ulp: add secure enclave node ---
commit 0fca804b5890d1b30a2a6c7de7313c46555323fc
Author: Pankaj Gupta <[email protected]>

arm64: dts: imx8ulp: add secure enclave node

Add the EdgeLock Enclave (ELE) secure-enclave node to the i.MX8ULP SoC dtsi.
The node is kept disabled so it does not impose a reserved-memory requirement
on every board.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index c6d1bb9edf388..38233dd74ee33 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi

[ ... ]

> @@ -185,6 +185,14 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +			status = "disabled";
> +		};

[Severity: Medium]
Will this node definition trigger dt-validate schema errors during make
dtbs_check?

Looking at Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml, the
schema unconditionally requires the memory-region property for this compatible:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - fsl,imx8ulp-se-ele-hsm
              - fsl,imx93-se-ele-hsm
    then:
      required:
        - memory-region

Since dt-validate checks all nodes regardless of their status = "disabled"
property, omitting memory-region here means any board devicetree that includes
imx8ulp.dtsi but leaves this node disabled will fail validation.

>  	};
>  
>  	cm33: remoteproc-cm33 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6