Re: [PATCH v35 6/7] arm64: dts: imx8ulp: add secure enclave node

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added `hsm0` node lacks the mandatory `memory-region` property, causing a `dtbs_check` validation failure. Additionally, the file `imx8ulp-firmware.dtsi` referenced in the commit message is missing from the patch series.
--

--- Patch [6]: [PATCH v35 6/7] arm64: dts: imx8ulp: add secure enclave node ---
commit c890c3315c7900443e29c20509319084f32b21c7
Author: Pankaj Gupta <[email protected]>

arm64: dts: imx8ulp: add secure enclave node

Add the EdgeLock Enclave (ELE) secure-enclave node to the i.MX8ULP SoC
dtsi. The node is kept disabled so it does not impose a reserved-memory
requirement on every board, and the commit message notes that boards can
provide the memory-region by including imx8ulp-firmware.dtsi.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index c6d1bb9edf388..38233dd74ee33 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi

[ ... ]

> @@ -185,6 +185,14 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +			status = "disabled";
> +		};

[Severity: Medium]
Will adding this node without a memory-region property cause a dtbs_check
validation failure?

According to Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml, the
schema unconditionally enforces the memory-region requirement for this
compatible string:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - fsl,imx8ulp-se-ele-hsm
              - fsl,imx93-se-ele-hsm
    then:
      required:
        - memory-region

Even though the node is disabled, it seems any board including this dtsi
will fail device tree schema validation due to the missing required property.

Additionally, the commit message states:

> Boards enable the enclave and provide its memory-region by including
> imx8ulp-firmware.dtsi.

Is there a missing patch in this series? The imx8ulp-firmware.dtsi file
mentioned in the commit message does not appear to be included in this patch
or currently present in the tree.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6