Re: [PATCH net-next v4 0/4] net: mdio: support dynamic OF device changes
Andrew Lunn <[email protected]>
| Newsgroups | dev.linux.lists.imx,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-omap,org.kernel.vger.linux-pm,org.kernel.vger.linux-usb,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
> I guess it can also be used like this for live dt modification: A guess is not good enough. Give us a concrete, in kernel use cases. > AFAIU the patches other than the last one are still relevant regardless > since they are fixing a bunch of generic mdio safety issues in code that > has users since MDIO maps already change at runtime through non-OF > paths(i.e. SFP insertion/removal). Fixes are fine, but please word the commit message around real things that can happen in todays kernel. If it is a race condition, such bug reports often show the call stack of the two racing threads. Do you have a board with an SFP cage? Can you test your change. Andrew