Re: [PATCH v3 6/7] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch adds a blank line despite the changelog explicitly stating it was dropped in v2.
--

--- Patch [6]: [PATCH v3 6/7] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node ---
commit 71890897809f09d8572aca4c1562adf06208b09e
Author: Laurent Pinchart <[email protected]>

ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node

The clock-frequency property for camera sensors is deprecated. This commit
replaces it with assigned-clocks and assigned-clock-rates in the device tree
configuration.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> index ca4cb986efbc2..0cc05d084f9bf 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> @@ -233,7 +233,9 @@ camera@3c {
>  		pinctrl-0 = <&pinctrl_ov5645>;
>  		reg = <0x3c>;
>  		clocks = <&clks IMX6QDL_CLK_CKO2>;
> -		clock-frequency = <24000000>;
> +		assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
> +		assigned-clock-rates = <24000000>;
> +

[Severity: Low]
This isn't a bug, but the patch changelog mentions dropping the added blank
line for v2. It appears the blank line still made it into this version. 
Was this left in by accident?

>  		vdddo-supply = <&reg_1p8v>;
>  		vdda-supply = <&reg_2p8v>;
>  		vddd-supply = <&reg_1p5v>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6