Re: [PATCH v3 1/4] dt-bindings: lcdif: Add endpoint bus-width property
Krzysztof Kozlowski <[email protected]>
| Newsgroups | dev.linux.lists.imx,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 13/08/2026 10:56, Alexander Stein wrote: > Am Donnerstag, 13. August 2026, 10:34:02 CEST schrieb Francesco Dolcini: >> On Thu, Aug 13, 2026 at 10:10:43AM +0200, Krzysztof Kozlowski wrote: >>> On Wed, Aug 12, 2026 at 03:29:49PM +0200, Francesco Dolcini wrote: >>>> From: Francesco Dolcini <[email protected]> >>>> >>>> The DPI output of the LCD interface can be configured with a bus width >>>> of 16, 18, or 24 bits. Introduce a bus-width property to the output >>>> endpoint, specifying the number of parallel RGB bits connected. >>>> >>>> Signed-off-by: Francesco Dolcini <[email protected]> >>>> --- >>>> v3: use video-interfaces.yaml >>>> v2: use the common bus-width property instead of the legacy interface-pix-fmt >>>> --- >>>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>>> index 2dd0411ec651..1f3daf002707 100644 >>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>>> @@ -71,6 +71,15 @@ properties: >>>> $ref: /schemas/graph.yaml#/properties/port >>>> description: The LCDIF output port >>>> >>>> + properties: >>>> + endpoint: >>>> + $ref: /schemas/media/video-interfaces.yaml >>> >>> This won't work, you need to test your DTS. The port schema does not >>> allow video-interfaces properties. You need port-base, like in every >>> other case. >> >> Thanks for the review Krzysztof >> >> Given my testing was not ok, and I am not sure what I did wrong exactly >> on my tests, is this the change I should do? Yes >> >> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >> index 1f3daf002707..89cea0c14cf1 100644 >> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >> @@ -68,7 +68,8 @@ properties: >> maxItems: 1 >> >> port: >> - $ref: /schemas/graph.yaml#/properties/port >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> description: The LCDIF output port > > With that change: > Tested-by: Alexander Stein <[email protected]> Please do not. Build testing is not testing (in the meaning of "Tested-by" tag), otherwise where is Rob's tested-by tag for all the patches he build tested? Best regards, Krzysztof