Re: [PATCH 1/6] arm64: dts: freescale: imx8mp-verdin: Add Toradex Capacitive Touch Display 10.1" LVDS

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The panel node name 'panel-lvds-native' does not comply with the devicetree bindings for simple panels.
--

--- Patch [1]: [PATCH 1/6] arm64: dts: freescale: imx8mp-verdin: Add Toradex Capacitive Touch Display 10.1" LVDS ---
commit 9fa4254322a01ecfb1f9a0941237ecac9d2bf3f1
Author: Leonardo Costa <[email protected]>

arm64: dts: freescale: imx8mp-verdin: Add Toradex Capacitive Touch Display 10.1" LVDS

This commit adds a device tree overlay for the Toradex Capacitive Touch
Display 10.1" LVDS on Verdin iMX8M Plus carrier boards. It integrates the
LogicTechno LCD panel and an Atmel MaxTouch capacitive touch controller.

Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-101inch-lvds

[ ... ]

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-panel-cap-touch-10inch-lvds.dtso b/arch/arm64/boot/dts/freescale/imx8mp-verdin-panel-cap-touch-10inch-lvds.dtso
> new file mode 100644
> index 0000000000000..9079c6284dfae
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-panel-cap-touch-10inch-lvds.dtso
> @@ -0,0 +1,95 @@

[ ... ]

> +&{/} {
> +	panel-lvds-native {

[Severity: Low]
Does this node name comply with the generic panel devicetree binding schema?

The bindings generally require panel node names to match the regular
expression ^panel(@[0-9a-f]+)?$. Using panel-lvds-native might trigger a
schema validation warning when running make dtbs_check. 

Would it be better to name this node simply panel?

> +		compatible = "logictechno,lt170410-2whc";
> +		backlight = <&backlight>;
> +		power-supply = <&reg_3p3v>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1