Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Inconsistent compatible string naming due to mismatched hyphen.
--
--- Patch [3]: [PATCH v3 3/4] dt-bindings: arm: fsl: add the Colibri VF50 and VF61 on Iris ---
commit 04c8812c4587059c616ac3a5abaa28f6f14d974a
Author: Mehmet Fide <[email protected]>
dt-bindings: arm: fsl: add the Colibri VF50 and VF61 on Iris
This commit extends the evaluation board entries to include compatible
strings for the Toradex Colibri VF50 and VF61 modules on the Iris carrier
board.
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 86876311ec59a..6f95c17b363c0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1705,9 +1705,11 @@ properties:
> - fsl,vf610
> - fsl,vf610m4
>
> - - description: Toradex Colibri VF50 Module on Colibri Evaluation Board
> + - description: Toradex Colibri VF50 Module on a carrier board
> items:
> - - const: toradex,vf500-colibri_vf50-on-eval
> + - enum:
> + - toradex,vf500-colibri_vf50-on-eval
> + - toradex,vf500-colibri-vf50-on-iris
[Severity: Low]
This isn't a bug, but should this compatible string use an underscore for
colibri_vf50 to match the base module name?
The new string uses a hyphen, whereas the existing eval board compatible
uses toradex,vf500-colibri_vf50-on-eval. Could this inconsistency cause
confusion when parsing or authoring device trees?
> - const: toradex,vf500-colibri_vf50
> - const: fsl,vf500
[ ... ]
> - - description: Toradex Colibri VF61 Module on Colibri Evaluation Board
> + - description: Toradex Colibri VF61 Module on a carrier board
> items:
> - - const: toradex,vf610-colibri_vf61-on-eval
> + - enum:
> + - toradex,vf610-colibri_vf61-on-eval
> + - toradex,vf610-colibri-vf61-on-iris
[Severity: Low]
Does this compatible string also have a mismatched hyphen instead of an
underscore for the colibri_vf61 base module?
Like the VF50 entry above, maintaining the exact base module string as a
prefix would stay consistent with toradex,vf610-colibri_vf61-on-eval.
> - const: toradex,vf610-colibri_vf61
> - const: fsl,vf610
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.