Re: [PATCH 5/6] arm64: dts: freescale: imx8mp-verdin: Add Toradex DSI to LVDS adapter with the 10.1" V2 display

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree overlay introduces an undocumented vendor prefix ('optologic') and an undocumented panel compatible string ('optologic,scx1001511ggc49').
--

--- Patch [5]: [PATCH 5/6] arm64: dts: freescale: imx8mp-verdin: Add Toradex DSI to LVDS adapter with the 10.1" V2 display ---
commit b2139ef088f077532b33f4e92f5d9bfd6e20a265
Author: Leonardo Costa <[email protected]>

arm64: dts: freescale: imx8mp-verdin: Add Toradex DSI to LVDS adapter with the 10.1" V2 display

This commit adds a device tree overlay for the Toradex DSI to LVDS Adapter
with the Toradex Capacitive Touch Display 10.1" LVDS V2. The adapter connects
to the Verdin DSI_1 interface and uses a TI SN65DSI84 bridge to drive the
panel.

Link: https://developer.toradex.com/hardware/accessories/add-ons/dsi-lvds-adapter
Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-101inch-lvds

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-dsi-to-lvds-v2-panel-cap-touch-10inch.dtso b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dsi-to-lvds-v2-panel-cap-touch-10inch.dtso
> new file mode 100644
> index 0000000000000..32828e9bc5345
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dsi-to-lvds-v2-panel-cap-touch-10inch.dtso
[ ... ]
> +&{/} {
> +	panel-lvds-bridge {
> +		compatible = "optologic,scx1001511ggc49", "panel-lvds";

[Severity: Low]
Are the vendor prefix "optologic" and panel compatible string
"optologic,scx1001511ggc49" missing from the devicetree bindings?

Using undocumented compatible strings causes static analysis and
make dtbs_check warnings when running devicetree schema validation.
Should these be documented in the bindings prior to or alongside
this patch?

> +		backlight = <&backlight>;
> +		data-mapping = "vesa-24";
> +		power-supply = <&reg_dsi_lvds>;
> +		height-mm = <136>;
> +		width-mm = <217>;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5