Re: [PATCH 4/6] arm64: dts: freescale: imx8mp-verdin: Add Toradex Capacitive Touch Display 10.1" LVDS V2
Leonardo Costa <[email protected]>
| Newsgroups | dev.linux.lists.imx,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <tfw352zb7gtx7mjg4nqcgjojsesppbwhl76s4hc44gjexgkrdu@sw5tbvwanyan> |
On Thu, Aug 13, 2026 at 02:19:15PM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] The device tree overlay uses an undocumented vendor prefix `optologic` and compatible string `optologic,scx1001511ggc49`. > -- > > --- Patch [4]: [PATCH 4/6] arm64: dts: freescale: imx8mp-verdin: Add Toradex Capacitive Touch Display 10.1" LVDS V2 --- > commit ae998202e5daf5ce215671d831b6ffc33e8604ec > Author: Leonardo Costa <[email protected]> > > arm64: dts: freescale: imx8mp-verdin: Add Toradex Capacitive Touch Display 10.1" LVDS V2 > > This commit adds a device tree overlay for the Toradex Capacitive Touch > Display 10.1" LVDS V2. The display is connected via Verdin iMX8M Plus LCDIF > and features an Opto Logic TFT LCD with an ILITEK capacitive touch controller. > > Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-101inch-lvds > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-panel-cap-touch-10inch-lvds-v2.dtso b/arch/arm64/boot/dts/freescale/imx8mp-verdin-panel-cap-touch-10inch-lvds-v2.dtso > > new file mode 100644 > > index 0000000000000..6b0c1a10ae2a9 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-panel-cap-touch-10inch-lvds-v2.dtso > > [ ... ] > > > +&{/} { > > + panel-lvds-native { > > + compatible = "optologic,scx1001511ggc49", "panel-lvds"; > > [Severity: Low] > Does this code introduce an undocumented vendor prefix and compatible string? > The prefix `optologic` and compatible string `optologic,scx1001511ggc49` > appear to be completely missing from `Documentation/devicetree/bindings/`, > which will cause the Device Tree binding checker to emit warnings when > validating the DT with `make dtbs_check`. > > > + backlight = <&backlight>; > > + data-mapping = "vesa-24"; > > + power-supply = <®_3p3v>; > > -- > Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4 As specified in the cover letter, these patches should be applied after another series: - https://lore.kernel.org/linux-arm-kernel/[email protected]/T/#t This series adds the compatible binding strings, and is currently in linux-next.