Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit silently modifies the `&sai1` node to add `pll8k` and `pll11k` clocks and their associated names, without any mention in the commit message. The commit message strictly claims to add the MQS1 pinmux and label conflicting devices for a future overlay.
--
--- Patch [13]: [PATCH 13/17] arm64: dts: imx95-15x15-evk: Add pinmux and mark conflicting devices for MQS1 ---
commit df407242391b2a2d45fd52f25207318251e36b7f
Author: Chancel Liu <[email protected]>
arm64: dts: imx95-15x15-evk: Add pinmux and mark conflicting devices for MQS1
This commit adds the MQS1 pinctrl group and labels conflicting devices for
a shared imx9-mqs overlay.
> diff --git a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> index aaa2608793bf6..1013bbfc08b31 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
[ ... ]
> @@ -592,6 +597,11 @@ &pcie0_port0 {
> };
>
> &sai1 {
> + clocks = <&scmi_clk IMX95_CLK_BUSAON>, <&dummy>,
> + <&scmi_clk IMX95_CLK_SAI1>, <&dummy>,
> + <&dummy>, <&scmi_clk IMX95_CLK_AUDIOPLL1>,
> + <&scmi_clk IMX95_CLK_AUDIOPLL2>;
> + clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3", "pll8k", "pll11k";
[Severity: Medium]
This isn't a bug, but could the commit message be updated to mention these
additions to &sai1?
The commit message strictly claims to add the MQS1 pinmux and label
conflicting devices for a future overlay. It does not mention adding the
pll8k and pll11k clocks and their associated names to the &sai1 node.
Does this omission mask a change in the dynamic clock switching behavior
of the fsl_sai driver?
Should these clock additions be split into a separate patch, or documented
in the commit message for this one?
> assigned-clocks = <&scmi_clk IMX95_CLK_AUDIOPLL1_VCO>,
> <&scmi_clk IMX95_CLK_AUDIOPLL2_VCO>,
> <&scmi_clk IMX95_CLK_AUDIOPLL1>,
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=13
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.