Re: [PATCH 17/17] arm64: dts: fsl: Add DT overlay to build MQS1 sound cards on i.MX9 platforms

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The MQS overlay orphans the `sound-micfil` ASoC card, leading to an indefinite deferred probe.
--

--- Patch [17]: [PATCH 17/17] arm64: dts: fsl: Add DT overlay to build MQS1 sound cards on i.MX9 platforms ---
commit 3fb4d43fd09e2139234f5b149b073a22039d004c
Author: Chancel Liu <[email protected]>

arm64: dts: fsl: Add DT overlay to build MQS1 sound cards on i.MX9 platforms

This commit adds a common DT overlay to support MQS sound cards on i.MX9
platforms. It routes SAI1 to MQS1 and disables conflicting devices and sound
cards.

> diff --git a/arch/arm64/boot/dts/freescale/imx9-mqs.dtso b/arch/arm64/boot/dts/freescale/imx9-mqs.dtso
> new file mode 100644
> index 0000000000000..9ac6d58eacbb9
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx9-mqs.dtso
[ ... ]
> +&mqs1_conflict_card {
> +	status = "disabled";
> +};
> +
> +&mqs1_conflict_dev {
> +	status = "disabled";
> +};

[Severity: Medium]
When the MQS overlay is applied on boards like imx93-11x11-evk.dts, this
disables the conflicting device (which aliases to &micfil), but does it leave
its consumer sound-micfil active?

Looking at arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts:

	sound-micfil {
		compatible = "fsl,imx-audio-card";
		model = "micfil-audio";

		pri-dai-link {
			link-name = "micfil hifi";
			format = "i2s";

			cpu {
				sound-dai = <&micfil>;
			};
		};
	};

If sound-micfil is not explicitly disabled by an alias here (such as
mqs1_conflict_card2), will the audio subsystem repeatedly attempt to probe it
since its CPU component (&micfil) is missing, resulting in an endless deferred
probe loop?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=17