Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete Kconfig dependency preparation: VIDEO_QCOM_IRIS also selects QCOM_UBWC_CONFIG without a QCOM_SMEM guard.
--
--- Patch [1]: [PATCH v5 1/3] drm/msm: Guard the QCOM_UBWC_CONFIG select with QCOM_SMEM ---
commit 720508af65c7d5604eab7fac5015d0cc98c646e0
Author: Daniel Baluta <[email protected]>
drm/msm: Guard the QCOM_UBWC_CONFIG select with QCOM_SMEM
This commit prepares DRM_MSM for an upcoming change where QCOM_UBWC_CONFIG
will depend on QCOM_SMEM. It guards the select statement and adds a dependency
to prevent a built-in DRM_MSM from selecting against a modular SMEM.
Fixes: 1b445022d1d0 ("soc: qcom: ubwc: Get HBB from SMEM")
> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index 09469d56513b0..ed1c4775d1e92 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
[ ... ]
> @@ -22,7 +23,7 @@ config DRM_MSM
> select TMPFS
> select QCOM_SCM
> select QCOM_PAS
> - select QCOM_UBWC_CONFIG
> + select QCOM_UBWC_CONFIG if ARCH_QCOM && QCOM_SMEM
[Severity: Low]
Will the upcoming change to make QCOM_UBWC_CONFIG depend on QCOM_SMEM
trigger Kconfig unmet direct dependency warnings elsewhere?
It looks like VIDEO_QCOM_IRIS also unconditionally selects QCOM_UBWC_CONFIG:
drivers/media/platform/qcom/iris/Kconfig:
config VIDEO_QCOM_IRIS
...
select QCOM_UBWC_CONFIG
If the SMEM dependency lands before the iris driver is updated, could this
cause a build breakage when compiling with VIDEO_QCOM_IRIS=y and QCOM_SMEM=n?
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.