Re: [PATCH v6 0/4] soc: qcom: ubwc: Fix link error when QCOM_SMEM=n
Nathan Chancellor <[email protected]>
| Newsgroups | dev.linux.lists.imx,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260817181743.GB1249844@ax162> |
Hi Daniel, On Mon, Aug 17, 2026 at 03:35:37PM +0300, Daniel Baluta wrote: > DRM_MSM and VIDEO_QCOM_IRIS select QCOM_UBWC_CONFIG, whose > ubwc_config.c calls QCOM_SMEM APIs unconditionally. On configs without > QCOM_SMEM this fails to link, e.g. on SOC_IMX5: > > arm-linux-gnueabihf-ld: ubwc_config.c:(.text+0x2c): undefined > reference to 'qcom_smem_is_available' > > Fix it by making the QCOM_SMEM requirement explicit in Kconfig. > > Changes since v5: > * added patch 4/4 to this series, which was initially sent as a > standalone patch (addresses review from Nathan) > * no other change to the series. > * picked up all R-b and Acked-by tags. > > Link to v5: https://lore.kernel.org/imx/[email protected]/T/#t > > Daniel Baluta (4): > drm/msm: Guard the QCOM_UBWC_CONFIG select with QCOM_SMEM > media: iris: Guard the QCOM_UBWC_CONFIG select with QCOM_SMEM > soc: qcom: ubwc: Fix link error when QCOM_SMEM=n > soc: qcom: ubwc: Fix missing include > > drivers/gpu/drm/msm/Kconfig | 3 ++- > drivers/media/platform/qcom/iris/Kconfig | 3 ++- > drivers/soc/qcom/Kconfig | 1 + > include/linux/soc/qcom/ubwc.h | 1 + > 4 files changed, 6 insertions(+), 2 deletions(-) Thanks, this resolves the build errors that I noticed. Tested-by: Nathan Chancellor <[email protected]> # build -- Cheers, Nathan