Re: [PATCH v37 1/7] Documentation/firmware: add imx/se to other_interfaces
| Newsgroups | dev.linux.lists.imx,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The kernel-doc directive references a non-existent file (`drivers/firmware/imx/se_ctrl.c`), which will cause Sphinx builds to fail or emit warnings. -- --- Patch [1]: [PATCH v37 1/7] Documentation/firmware: add imx/se to other_interfaces --- commit ac0ee8751fff1b6f43a912d3cdc22822ca9395fb Author: Pankaj Gupta <[email protected]> Documentation/firmware: add imx/se to other_interfaces This commit documents the i.MX SoC's Service layer and C_DEV driver for selected SoCs containing NXP hardware IPs for Secure Enclaves. > diff --git a/Documentation/driver-api/firmware/other_interfaces.rst b/Documentation/driver-api/firmware/other_interfaces.rst > index 06ac89adaafba..6c6fa9a0ba1df 100644 > --- a/Documentation/driver-api/firmware/other_interfaces.rst > +++ b/Documentation/driver-api/firmware/other_interfaces.rst [ ... ] > +When a user sends a command to the firmware, it registers its device_ctx > +as waiter of a response from firmware. > + > +Enclave's Firmware owns the storage management over a Linux filesystem. > +For this c_dev provisions a dedicated slave device called "receiver". > + > +.. kernel-doc:: drivers/firmware/imx/se_ctrl.c > + :export: [Severity: Low] Does drivers/firmware/imx/se_ctrl.c exist at this point in the tree? Referencing a non-existent file in a kernel-doc directive will cause the Sphinx documentation build to emit warnings or fail. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1