Re: [PATCH v37 6/7] arm64: dts: imx8ulp: add secure enclave node

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `hsm0: secure-enclave` node lacks the required `memory-region` property, and the `imx8ulp-firmware.dtsi` file mentioned in the commit message is missing.
--

--- Patch [6]: [PATCH v37 6/7] arm64: dts: imx8ulp: add secure enclave node ---
commit 2ba9b9f0319499b595df7fe3ea1566a81890865d
Author: Pankaj Gupta <[email protected]>

arm64: dts: imx8ulp: add secure enclave node

This commit adds the EdgeLock Enclave (ELE) secure-enclave node to the
i.MX8ULP SoC dtsi. It also adds a label for sram@2201f000 that the node
references, while keeping the node disabled by default to avoid imposing
memory requirements.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index c6d1bb9edf388..38233dd74ee33 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
[ ... ]
> @@ -185,6 +185,14 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +			status = "disabled";
> +		};

[Severity: Medium]
Will this trigger a schema validation warning during make dtbs_check?

The fsl,imx-se.yaml binding strictly requires the memory-region property
for fsl,imx8ulp-se-ele-hsm. Since disabled nodes are validated by default,
leaving memory-region out of this base node causes validation to fail.

Additionally, the commit message mentions boards provide this property by
including imx8ulp-firmware.dtsi, but is that file missing from this patch
series?

>  	};
>  
>  	cm33: remoteproc-cm33 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6