Re: [PATCH v39 6/7] arm64: dts: imx8ulp: add secure enclave node

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `hsm0` node added to `imx8ulp.dtsi` lacks the `memory-region` property, which will cause `dtbs_check` schema validation to fail for any board that leaves the node disabled.
--

--- Patch [6]: [PATCH v39 6/7] arm64: dts: imx8ulp: add secure enclave node ---
commit 2df947c02e3ec38b8653aed8492f9d709b178160
Author: Pankaj Gupta <[email protected]>

arm64: dts: imx8ulp: add secure enclave node

This commit adds the EdgeLock Enclave (ELE) secure-enclave node to the
i.MX8ULP SoC dtsi. The node is kept disabled by default so it doesn't impose
a reserved-memory requirement on every board.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
[ ... ]
> @@ -185,6 +185,14 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +			status = "disabled";
> +		};

[Severity: Low]
Will this missing memory-region property cause dtbs_check schema validation
to fail for boards that leave the node disabled?

The DT schema fsl,imx-se.yaml requires the memory-region property for the
fsl,imx8ulp-se-ele-hsm compatible unconditionally. Because dt-validate
evaluates all nodes in the resulting DTB, including those with
status = "disabled", any board including imx8ulp.dtsi that does not enable
the enclave and provide a memory-region will trigger a validation warning.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6