Re: [PATCH v1 3/3] ARM: dts: imx7d: add Variscite MX7CustomBoard support

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

New issues:
- [Medium] The V2 hardware revision variants with the WM8731 codec are missing, despite the commit message claiming to support them.

Pre-existing issues:
- [Medium] The `assigned-clock-rates` property is defined twice in the `&sai1` node.
--

--- Patch [3]: [PATCH v1 3/3] ARM: dts: imx7d: add Variscite MX7CustomBoard support ---
commit 453bab576a5d3f561e4803a647eb9654e584d623
Author: Stefano Radaelli <[email protected]>

ARM: dts: imx7d: add Variscite MX7CustomBoard support

Add device tree support for the Variscite MX7CustomBoard carrier board with
the VAR-SOM-MX7 system on module. This includes supported board configurations
for both VAR-SOM-MX7 hardware revisions (eMMC, NAND, and WM8731 variants),
and adds the resulting DTBs to the i.MX7D device tree Makefile.

Link: https://www.variscite.com/carrier-boards/var-mx7customboard/

> diff --git a/arch/arm/boot/dts/nxp/imx/Makefile b/arch/arm/boot/dts/nxp/imx/Makefile
> index 1a2539fa19b44..37da667f9ffb0 100644
> --- a/arch/arm/boot/dts/nxp/imx/Makefile
> +++ b/arch/arm/boot/dts/nxp/imx/Makefile
> @@ -444,6 +444,12 @@ dtb-$(CONFIG_SOC_IMX7D) += \
>  	imx7d-sdb-reva.dtb \
>  	imx7d-sdb-sht11.dtb \
>  	imx7d-smegw01.dtb \
> +	imx7d-var-som-emmc-mx7customboard.dtb \
> +	imx7d-var-som-emmc-wm8731-mx7customboard.dtb \
> +	imx7d-var-som-nand-mx7customboard.dtb \
> +	imx7d-var-som-nand-wm8731-mx7customboard.dtb \
> +	imx7d-var-som-v2-emmc-mx7customboard.dtb \
> +	imx7d-var-som-v2-nand-mx7customboard.dtb \

[Severity: Medium]
Are the V2 hardware revision variants with the WM8731 codec missing here?

The commit message states that configurations for both hardware revisions
include the WM8731 variants, but it seems there are no dtb targets (nor
source dts files) added for V2 with WM8731.

[ ... ]

> diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-var-som-emmc-wm8731-mx7customboard.dts b/arch/arm/boot/dts/nxp/imx/imx7d-var-som-emmc-wm8731-mx7customboard.dts
> new file mode 100644
> index 0000000000000..94c4b1fa5d6c3
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx7d-var-som-emmc-wm8731-mx7customboard.dts
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * VAR-MX7CustomBoard for VAR-SOM-MX7 with eMMC and WM8731
> + *
> + * Link: https://variscite.com/carrier-boards/var-mx7customboard/
> + *
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com/
> + *
> + */
> +
> +/dts-v1/;
> +
> +#include "imx7d-var-som.dtsi"
> +#include "imx7d-var-som-emmc.dtsi"
> +#include "imx7d-var-som-wm8731.dtsi"

[Severity: Medium]
This is a pre-existing issue, but does the included imx7d-var-som-wm8731.dtsi
file define the assigned-clock-rates property twice?

Looking at &sai1 in arch/arm/boot/dts/nxp/imx/imx7d-var-som-wm8731.dtsi:

&sai1 {
	assigned-clock-rates = <0>, <36864000>;
	assigned-clocks = <&clks IMX7D_AUDIO_MCLK_ROOT_SRC>,
			  <&clks IMX7D_AUDIO_MCLK_ROOT_DIV>;
	assigned-clock-parents = <&clks IMX7D_PLL_AUDIO_POST_DIV>;
	assigned-clock-rates = <0>, <12288000>;
	/delete-property/ fsl,sai-mclk-direction-output;
};

The assigned-clock-rates property is defined twice, which causes a device
tree compiler warning and ambiguity about which clock rates are intended.

Could this lead to incorrect clock configuration and non-working audio
when this file is included?

> +#include "imx7d-var-som-mx7customboard.dtsi"
> +
> +/ {
> +	model = "Variscite VAR-SOM-MX7 with eMMC & WM8731 on VAR-MX7CustomBoard";
> +	compatible = "variscite,var-som-imx7d-emmc-wm8731-mx7customboard",
> +		     "variscite,var-som-imx7d",
> +		     "fsl,imx7d";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3