Re: [PATCH] iommu/dma: fix grammar in comments

On 2026-07-22 10:41 pm, Will Deacon wrote:
> On Tue, Jul 14, 2026 at 10:45:02AM +0800, weimin xiong wrote:
>> From: xiongweimin <[email protected]>
>>
>> Clarify two slightly mangled DMA-IOMMU mapping comments.
>>
>> Signed-off-by: xiongweimin <[email protected]>
>> ---
>>   drivers/iommu/dma-iommu.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
>> index 9abaec070..2c28b951f 100644
>> --- a/drivers/iommu/dma-iommu.c
>> +++ b/drivers/iommu/dma-iommu.c
>> @@ -1489,7 +1489,7 @@ int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg, int nents,
>>   		 *   based purely on segment lengths without needing to know
>>   		 *   the actual addresses beforehand.
>>   		 * - The mask must be a power of 2, so pad_len == 0 if
>> -		 *   iova_len == 0, thus we cannot dereference prev the first
>> +		 *   iova_len == 0, thus we cannot dereference prev, the first
> 
> I don't think adding the extra comma makes much sense here:        ^.

Indeed, "the first time through here" is not a separate clause, it makes 
no grammatical sense on its own. The existing sentence is correct.

("it the address" does appear to be botched editing on my part though, 
oops!)

Thanks,
Robin.

(Whose email provider sends 163.com and various other domains straight 
to /dev/null, not even quarantine...)

> I'll hoover up your other typo fixes onto their own 'typo' branch and
> leave it up to Joerg as to whether he decides to apply/squash/ignore
> them.
> 
> Will