Re: [PATCH v3] iommu/msm: Fix dangling list entry on probe failure

On Fri, Jul 24, 2026 at 01:33:37PM +0100, Will Deacon wrote:
> On Thu, Jul 23, 2026 at 10:19:44PM +0530, Mukesh Ojha wrote:
> > On Wed, Jul 22, 2026 at 10:39:34PM +0100, Will Deacon wrote:
> > > On Thu, 16 Jul 2026 16:53:12 +0800, Weimin Xiong wrote:
> > > > Move the list_add() call to the end of msm_iommu_probe() instead of
> > > > adding cleanup paths, which avoids the dangling list entry problem
> > > > entirely (suggested by Mukesh Ojha).
> > > > 
> > > > This approach simplifies the code by ensuring the iommu device is
> > > > never added to the global list until after all potential failure
> > > > points have passed.
> > > > 
> > > > [...]
> > > 
> > > Applied to iommu (qualcomm/msm), thanks!
> > > 
> > > [1/1] iommu/msm: Fix dangling list entry on probe failure
> > >       https://git.kernel.org/iommu/c/6bea37b176b8
> > 
> > Will,
> > 
> > By mistake you have taken the wrong one; it should be v2, not v3 that
> > should be picked. Sorry for the confusion.
> 
> Damn, so close!
> 
> I had already realised I wanted the v2, so I'd flagged that to be applied
> and marked the v3 as "read". I then carefully passed the message-id of
> v2 to my wrapper script around b4...
> 
> ... which invokes b4 with the '-c' option, causing it to check for newer
> revisions. D'oh!

Urgh, v3 is a reply to v2 so even without that option is still gets the
wrong patch. I'll just apply it manually.

> I think I'll just revert the v3 and try again with the v2.

On second thoughts, I'll replace the patch to avoid confusion with stable.

Will