Re: [PATCH 4/4] iommupt: Return zero for invalid iova_to_phys() ranges
Baolu Lu <[email protected]> Wed, 29 Jul 2026 10:59:52 +0800
| Newsgroups | dev.linux.lists.iommu,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 7/26/26 15:43, Shuai Xue wrote:
> DOMAIN_NS(iova_to_phys) returns a phys_addr_t and follows the IOMMU
> iova_to_phys() convention of returning 0 when there is no valid
> translation.
>
> make_range() returns a negative errno if the input IOVA cannot be
> represented by this page table format. Returning that errno directly
> casts it to phys_addr_t. Callers treat zero as no translation and use
> non-zero values as physical addresses, so this can make them consume a
> bogus physical address instead of seeing a failed translation.
>
> Match the page-table walk failure path and return 0 for range validation
> failures too.
>
> Fixes: 9d4c274cd7d5 ("iommupt: Add iova_to_phys op")
> Cc:[email protected]
> Assisted-by:Qoder:Qwen-3.8-MAX-Preview
> Signed-off-by: Shuai Xue<[email protected]>
> ---
> drivers/iommu/generic_pt/iommu_pt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Lu Baolu <[email protected]>