Re: [PATCH v7 03/10] dt-bindings: power: rockchip: allow resets in a power domain node
Krzysztof Kozlowski <[email protected]>
| Newsgroups | dev.linux.lists.iommu,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <20260813-squid-of-splendid-hail-d968bf@quoll> |
On Wed, Aug 12, 2026 at 09:40:58PM +1200, Jiaxing Hu wrote: > Some domains do not come up in a usable state on their own and need > their resets cycled once power is on. The RK3576 NPU domains are one > case: without it the first access after power-on takes an async SError. > > pd-node has no resets property and every nesting level is > unevaluatedProperties: false, so describing that in DT is rejected > today. Add it alongside clocks. This paragraph is redundant. Why are you explaining correct syntax? > > Signed-off-by: Jiaxing Hu <[email protected]> > --- > .../bindings/power/rockchip,power-controller.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml > index b41db576f..f23c1a118 100644 > --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml > +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml > @@ -136,6 +136,14 @@ $defs: > A number of phandles to clocks that need to be enabled > while power domain switches state. > > + resets: > + minItems: 1 > + maxItems: 30 30 resets per one power domain? and none got to the example in this file? > + description: | Do not need '|' unless you need to preserve formatting. > + A number of phandles to resets that need to be cycled once the power > + domain has been switched on, for domains whose logic does not come up > + in a usable state by itself. > + > domain-supply: > description: domain regulator supply. > > -- > 2.43.0 >