Re: [PATCH v9 04/12] iommu/arm-smmu-v3: Destroy vmid_map ida via devres

Jason Gunthorpe <[email protected]>
Newsgroups dev.linux.lists.iommu,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel
Message-ID <178735412600.18212.2050664519547226046.b4-review@b4>
On Tue, 21 Jul 2026 12:48:13 -0700, Nicolin Chen <[email protected]> wrote:
> The vmid_map ida is only destroyed in arm_smmu_device_remove(), which does
> not run when the probe fails. This is currently harmless, as the ida stays
> empty until the first S2 domain allocation, which can only happen after a
> successful probe.
> 
> An upcoming change will start reserving the crashed kernel's VMIDs in this
> ida, at the probe time of a kdump kernel. A probe failure would then leak
> the ida's internal allocations.
> 
> [...]

Reviewed-by: Jason Gunthorpe <[email protected]>

-- 
Jason
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.