Re: [PATCH 3/3] x86/irq, iommu/amd, PCI: Drop redundant irq_retrigger inits
Naman Jain <[email protected]>
| Newsgroups | dev.linux.lists.iommu,org.kernel.vger.linux-hyperv,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
On 8/24/2026 5:47 AM, Wei Liu wrote:
> On Tue, Jul 28, 2026 at 01:51:17PM +0000, Naman Jain wrote:
> [...]
>> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
>> index ea3377e61aa5c..0c362e86a09d9 100644
>> --- a/drivers/iommu/amd/init.c
>> +++ b/drivers/iommu/amd/init.c
>> @@ -2468,7 +2468,6 @@ static struct irq_chip intcapxt_controller = {
>> .irq_unmask = intcapxt_unmask_irq,
>> .irq_mask = intcapxt_mask_irq,
>> .irq_ack = irq_chip_ack_parent,
>> - .irq_retrigger = irq_chip_retrigger_hierarchy,
>> .irq_set_affinity = intcapxt_set_affinity,
>> .irq_set_wake = intcapxt_set_wake,
>> .flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_MOVE_DEFERRED,
>> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
>> index 89816a2bd7cd3..cfc8fa403dad6 100644
>> --- a/drivers/pci/controller/pci-hyperv.c
>> +++ b/drivers/pci/controller/pci-hyperv.c
>> @@ -2119,7 +2119,6 @@ static bool hv_pcie_init_dev_msi_info(struct device *dev, struct irq_domain *dom
>> info->ops->msi_prepare = hv_msi_prepare;
>>
>> chip->irq_set_affinity = irq_chip_set_affinity_parent;
>> - chip->irq_retrigger = irq_chip_retrigger_hierarchy;
>
> Acked-by: Wei Liu <[email protected]>.
>
> I suppose you do this because the first patch is supposed to be
> backported.
>
> Wei
Yes, exactly.
Regards,
Naman