Re: [PATCH v3 1/5] iommu/amd: Refactor device probe and capability initialization
Jason Gunthorpe <[email protected]>
| Newsgroups | dev.linux.lists.iommu,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <178759520116.3131778.9383172724893797706.b4-review@b4> |
> [ ... 14 lines skipped ... ]
> @@ -675,7 +675,8 @@ static void pdev_disable_caps(struct pci_dev *pdev)
> * This function checks if the driver got a valid device from the caller to
> * avoid dereferencing invalid pointers.
> */
> -static bool check_device(struct device *dev)
> +static bool iommu_lookup_device(struct device *dev,
> + struct amd_iommu **iommu_out, u16 *devid_out)
> {
If we are touching the names driver functions should not be called
iommu_*, it is confusing..
Otherwise looks OK
Reviewed-by: Jason Gunthorpe <[email protected]>
--
Jason