Re: [PATCH v2 1/4] monitor: add --time-format,-t option

Denis Kenzior <[email protected]>
Newsgroups dev.linux.lists.iwd
Message-ID <[email protected]>
Hi James,

On 12/2/24 8:54 AM, James Prestwood wrote:
> For syncing iwmon captures with other logging its useful to
> timestamp in some absolute format like UTC. This adds an
> option which allows the user to specify what time format to
> show. For now support:
> 
> delta - (default) The time delta between the first packet
>          and the current packet.
> utc   - The packet time in UTC
> ---
>   monitor/main.c  | 56 ++++++++++++++++++++++++++++++-------------------
>   monitor/nlmon.c | 45 +++++++++++++++++++++++++++++++++------
>   monitor/nlmon.h |  6 ++++++
>   3 files changed, 80 insertions(+), 27 deletions(-)
> 
> v2:
>   * Fix compiler warning on musl. The switch statement checking the
>     time format had no default case which would cause 'n' to be
>     uninitialized. Its an impossible condition least with the
>     current code base, but it doesn't hurt to add a default to
>     future proof.
> 

All applied, thanks.

Regards,
-Denis
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.