Re: [RFC] netdev: destroy auth-proto in connect event, for ext auth

Hi James,

On 12/19/24 6:44 AM, James Prestwood wrote:
> With external auth there is no associate event meaning the auth proto
> never gets freed, which prevents eapol from starting inside the
> OCI callback. Check for this specific case and free the auth proto
> in the connect event.
> ---
>   src/netdev.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 

<snip>

> @@ -2821,6 +2823,16 @@ process_resp_ies:
>   
>   	l_debug("Request / Response IEs parsed");
>   
> +	/*
> +	 * This should only be the case for Fullmac/External auth. Here we don't
> +	 * get an associate event, so we need to destroy the auth-proto now
> +	 * so eapol gets started within the OCI callback
> +	 */
> +	if (netdev->ap && nhs->type == CONNECTION_TYPE_FULLMAC) {
> +		auth_proto_free(netdev->ap);
> +		netdev->ap = NULL;
> +	}
> +

Would this be better done in netdev_external_auth_sae_tx_associate() instead?

>   	if (netdev->sm) {
>   		if (!hs->chandef) {
>   			if (netdev_get_oci(netdev) < 0)

Regards,
-Denis